Adds ability to filter the set of tests that are run by a bot

scripts/slave/recipe_modules/filter/example.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 DEPS = [
   'filter',
+  'json',
   'path',
   'properties',
   'raw_io',
 ]
 
 def GenSteps(api):
   api.path['checkout'] = api.path['slave_build']
   api.filter.does_patch_require_compile()
   assert (api.filter.result and api.properties['example_result']) or \
       (not api.filter.result and not api.properties['example_result'])
+  assert (not api.properties['example_matching_exes'] or
+          list(api.properties['example_matching_exes']) ==
+          api.filter.matching_exes)
 
 def GenTests(api):
   # Trivial test with no exclusions and nothing matching.
   yield (api.test('basic') +
          api.properties(filter_exclusions=[]) +
          api.properties(example_result=None) +
+         api.properties(example_matching_exes=None) +
          api.override_step_data(
           'analyze',
-          api.raw_io.stream_output('xx')) +
+          stdout=api.json.output({'status': 'No dependency'})) +
          api.override_step_data(
           'git diff to analyze patch',
           api.raw_io.stream_output('yy')))
   
   # Matches exclusions
   yield (api.test('match_exclusion') +
          api.properties(filter_exclusions=['fo.*']) +
          api.properties(example_result=1) +
+         api.properties(example_matching_exes=None) +
          api.override_step_data(
           'git diff to analyze patch',
           api.raw_io.stream_output('foo.cc')))
 
   # Doesnt match exclusion.
   yield (api.test('doesnt_match_exclusion') +
          api.properties(filter_exclusions=['fo.*']) +
          api.properties(example_result=None) +
+         api.properties(example_matching_exes=None) +
          api.override_step_data(
           'analyze',
-          api.raw_io.stream_output('xx')) +
+          stdout=api.json.output({'status': 'No dependency'})) +

[iannucci, 2014/07/30 01:20:37]

just wondering... there's not a way to actually have the analyze step write to a
file, is there? that would let you actually have debugging/log statements on
stdout.

also be aware that stdout/stderr are not tee'd, so unless you write to stderr,
there will be no output from your analyze step until it's complete (and then the
output will only show up on the json.output link, I think).

[sky, 2014/07/30 21:14:16]

I changed the analyze code to do that. It simplified things and I was able to
add use override_step_data again and have default step_test_data.
The output is written at the very end, so it shouldn't be an issue.

          api.override_step_data(
           'git diff to analyze patch',
           api.raw_io.stream_output('bar.cc')))
 
   # Analyze returns matching result.
   yield (api.test('analyzes_returns_true') +
          api.properties(example_result=1) +
+         api.properties(example_matching_exes=None) +
          api.override_step_data(
           'analyze',
-          api.raw_io.stream_output('Found dependency')))
+          stdout=api.json.output({'status': 'Found dependency',
+                                  'targets': []})))
+
+  # Analyze returns matching tests.
+  yield (api.test('analyzes_matches_exes') +
+         api.properties(matching_exes=['foo', 'bar']) +
+         api.properties(example_matching_exes=['foo']) +
+         api.properties(example_result=1) +
+         api.override_step_data(
+          'analyze',
+          stdout=api.json.output({'status': 'Found dependency',
+                                  'targets': ['foo']})))
+
+  # Analyze with error condition.
+  yield (api.test('analyzes_error') +
+         api.properties(matching_exes=None) +
+         api.properties(example_matching_exes=None) +
+         api.properties(example_result=1) +
+         api.override_step_data(
+          'analyze',
+          stdout=api.json.output({'error': 'ERROR'})))