Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 427003008: Use placement new to allocate GPU command buffer entries. (Closed)

Created:
6 years, 4 months ago by jbauman
Modified:
6 years, 4 months ago
Reviewers:
jschuh
CC:
chromium-reviews, piman+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use placement new to allocate GPU command buffer entries. This isn't as ugly as the crazy null check, and it seems to be compiled correctly. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288481

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M gpu/command_buffer/client/cmd_buffer_helper.h View 1 3 chunks +3 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbauman
6 years, 4 months ago (2014-08-04 21:36:02 UTC) #1
jschuh
Still ugly, but much less ugly. lgtm
6 years, 4 months ago (2014-08-07 20:02:19 UTC) #2
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 4 months ago (2014-08-07 20:02:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/427003008/20001
6 years, 4 months ago (2014-08-07 20:06:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 01:22:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 01:44:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/3516)
6 years, 4 months ago (2014-08-08 01:44:31 UTC) #7
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 4 months ago (2014-08-09 00:40:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/427003008/20001
6 years, 4 months ago (2014-08-09 00:44:20 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 00:57:01 UTC) #10
Message was sent while issue was closed.
Change committed as 288481

Powered by Google App Engine
This is Rietveld 408576698