Issue 42690: A workaround fix for Issue 9186....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42690: A workaround fix for Issue 9186.... (Closed)

Created:
11 years, 9 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A workaround fix for Issue 9186. This crash is caused in a unnecessary check whether or not to add a "text direction" submenu to a context menu. Since we don't have a "text direction" submenu and this check is unnecessary now, this change set a page setting that disables this check. BUG=9186 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13072

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	webkit/glue/webview_impl.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

11 years, 9 months ago (2009-03-27 16:50:09 UTC) #2

lgtm

http://codereview.chromium.org/42690/diff/1/2
File webkit/glue/webview_impl.cc (right):

http://codereview.chromium.org/42690/diff/1/2#newcode1394
Line 1394: // avoid a crash while checking it.
Can you add a reference to where the crash is (Editor::hasBidiSelection)? BTW,
we may have to file a upstream bug about it (or is it us that need fix on our
side?)

Expand Messages | Collapse Messages