content/renderer/pepper/ppb_video_decoder_impl.cc - Issue 426873004: Pass decoded picture size from VDA to client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/ppb_video_decoder_impl.cc

Issue 426873004: Pass decoded picture size from VDA to client (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: change visible_size to visible_rect; add comments for visible_rect validation Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/ppb_video_decoder_impl.cc

diff --git a/content/renderer/pepper/ppb_video_decoder_impl.cc b/content/renderer/pepper/ppb_video_decoder_impl.cc

index 01be7b7f45debe69ce3fddf56ec922f9dde521b1..103f845c2dc157ac019bb96a3248ded8b94a78ba 100644

--- a/content/renderer/pepper/ppb_video_decoder_impl.cc

+++ b/content/renderer/pepper/ppb_video_decoder_impl.cc

@@ -246,6 +246,8 @@ void PPB_VideoDecoder_Impl::ProvidePictureBuffers(

}

void PPB_VideoDecoder_Impl::PictureReady(const media::Picture& picture) {

+ // So far picture.visible_rect is not used. If used, visible_rect should

+ // be validated since it comes from GPU process and may not be trustworthy.

DCHECK(RenderThreadImpl::current());

if (!ppp_videodecoder_)

return;