Pass decoded picture size from VDA to client

content/renderer/pepper/video_decoder_shim.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/video_decoder_shim.h"
 
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
 #include <GLES2/gl2extchromium.h>
 
@@ skipping 509 matching lines @@
     gles2->TexImage2D(GL_TEXTURE_2D,
                       0,
                       GL_RGBA,
                       texture_size_.width(),
                       texture_size_.height(),
                       0,
                       GL_RGBA,
                       GL_UNSIGNED_BYTE,
                       &frame->argb_pixels.front());
 
-    host_->PictureReady(media::Picture(texture_id, frame->decode_id));
+    host_->PictureReady(media::Picture(texture_id, frame->decode_id,
+                                       texture_size_));

[Pawel Osciak, 2014/08/10 00:02:21]

We should be passing visible size here, not coded size. You should be able to
get visible size from VideoFrame that comes into OnOutputComplete.

[kcwu, 2014/08/12 04:48:06]

I don't understand what you mean. texture_size_ here comes from
PendingFrame->size in OnOutputComplete (line 498). There is only one size in
PendingFrame.

[Pawel Osciak, 2014/08/12 04:59:24]

OnOutputComplete gets a VF, which has both coded and visible size. We only use
coded size from it. We should keep using coded size for texture/buffer size, but
pass visible size to PictureReady.

[kcwu, 2014/08/12 07:31:11]

Ah, I was confused with VideoDecoderShim::DecoderImpl::OnOutputComplete and
VideoDecoderShim::OnOutputComplete.
Anyway, done.

     pending_frames_.pop();
   }
 
   FlushCommandBuffer();
 
   if (pending_frames_.empty()) {
     // If frames aren't backing up, notify the host of any completed decodes so
     // it can send more buffers.
     NotifyCompletedDecodes();
 
@@ skipping 39 matching lines @@
 void VideoDecoderShim::DeleteTexture(uint32_t texture_id) {
   gpu::gles2::GLES2Interface* gles2 = context_provider_->ContextGL();
   gles2->DeleteTextures(1, &texture_id);
 }
 
 void VideoDecoderShim::FlushCommandBuffer() {
   context_provider_->ContextGL()->Flush();
 }
 
 }  // namespace content