Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 42687: Add a test to test_shell_tests to verify that navigator.plugins.refresh() wor... (Closed)

Created:
11 years, 9 months ago by jam
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a test to test_shell_tests to verify that navigator.plugins.refresh() works. Also get rid of the duplicate disabled verify_plugin_window_rect test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12725

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -145 lines) Patch
D webkit/data/plugin_tests/npapi.js View 1 chunk +0 lines, -28 lines 0 comments Download
D webkit/data/plugin_tests/verify_plugin_window_rect.html View 1 chunk +0 lines, -30 lines 0 comments Download
M webkit/tools/test_shell/plugin_tests.cc View 1 2 1 chunk +54 lines, -87 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
11 years, 9 months ago (2009-03-27 03:23:30 UTC) #1
darin (slow to review)
LGTM ExecuteScript is very handy :) http://codereview.chromium.org/42687/diff/2001/2002 File webkit/tools/test_shell/plugin_tests.cc (right): http://codereview.chromium.org/42687/diff/2001/2002#newcode74 Line 74: webkit_glue::WebScriptSource refresh ...
11 years, 9 months ago (2009-03-27 06:26:27 UTC) #2
jam
done. Can I submit the upstream change which has been reviewed to third_party\WebKit and update ...
11 years, 9 months ago (2009-03-27 18:30:31 UTC) #3
darin (slow to review)
11 years, 9 months ago (2009-03-27 18:41:15 UTC) #4
OK, but please coordinate with whomever is doing the merge today.

Powered by Google App Engine
This is Rietveld 408576698