Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 426833005: Fix MIPS build: use stubbed-out TF implementation (Closed)

Created:
6 years, 4 months ago by danno
Modified:
6 years, 4 months ago
CC:
v8-dev, paul.l...
Project:
v8
Visibility:
Public.

Description

Fix MIPS build: use stubbed-out TF implementation R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22753

Patch Set 1 #

Patch Set 2 : Tweaks #

Total comments: 2

Patch Set 3 : Review feedback #

Patch Set 4 : White space fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -7 lines) Patch
M src/compiler/code-generator.cc View 1 2 chunks +52 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 6 chunks +42 lines, -2 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lithium-inl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-instruction-selector.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-pipeline.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danno
6 years, 4 months ago (2014-07-31 11:21:35 UTC) #1
titzer
https://codereview.chromium.org/426833005/diff/20001/src/compiler/instruction-selector.cc File src/compiler/instruction-selector.cc (right): https://codereview.chromium.org/426833005/diff/20001/src/compiler/instruction-selector.cc#newcode872 src/compiler/instruction-selector.cc:872: #if !V8_TURBOFAN_TARGET I think you can use the MACHINE_OP_LIST ...
6 years, 4 months ago (2014-07-31 11:26:22 UTC) #2
danno
Please take another look
6 years, 4 months ago (2014-07-31 11:44:55 UTC) #3
titzer
On 2014/07/31 11:44:55, danno wrote: > Please take another look lgtm
6 years, 4 months ago (2014-07-31 11:48:12 UTC) #4
danno
6 years, 4 months ago (2014-07-31 12:00:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r22753 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698