Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 426833004: Don't print errors to stderr in socket_*. (Closed)

Created:
6 years, 4 months ago by Anders Johnsen
Modified:
6 years, 4 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Don't print errors to stderr in socket_*. BUG=https://code.google.com/p/dart/issues/detail?id=20070 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=38660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -51 lines) Patch
M runtime/bin/socket_android.cc View 4 chunks +1 line, -17 lines 0 comments Download
M runtime/bin/socket_linux.cc View 4 chunks +1 line, -15 lines 0 comments Download
M runtime/bin/socket_macos.cc View 4 chunks +1 line, -17 lines 0 comments Download
M runtime/bin/socket_win.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 4 months ago (2014-07-29 07:02:18 UTC) #1
ricow1
lgtm
6 years, 4 months ago (2014-07-29 07:11:05 UTC) #2
Anders Johnsen
6 years, 4 months ago (2014-07-29 07:14:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38660 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698