Issue 426783006: Fix supervised user dialog close regression.

Issue 426783006: Fix supervised user dialog close regression. (Closed)

Created:
6 years, 4 months ago by Dan Beam

Modified:
6 years, 4 months ago

Reviewers:
michaelpg

CC:
chromium-reviews, dbeam+watch-options_chromium.org, pam+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, Marc Treib

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix supervised user dialog close regression. BUG=399686 R=michaelpg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287035

Patch Set 2 : remove rendundant diff #

Patch Set 3 : splitting #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/options/supervised_user_learn_more.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

michaelpg

lgtm, thanks! https://codereview.chromium.org/426783006/diff/1/chrome/browser/resources/options/manage_profile_overlay.js File chrome/browser/resources/options/manage_profile_overlay.js (right): https://codereview.chromium.org/426783006/diff/1/chrome/browser/resources/options/manage_profile_overlay.js#newcode120 chrome/browser/resources/options/manage_profile_overlay.js:120: PageManager.showPageByName('supervisedUserImport'); https://codereview.chromium.org/431303003/

6 years, 4 months ago (2014-08-01 17:07:54 UTC) #2

Dan Beam

https://codereview.chromium.org/426783006/diff/1/chrome/browser/resources/options/manage_profile_overlay.js File chrome/browser/resources/options/manage_profile_overlay.js (right): https://codereview.chromium.org/426783006/diff/1/chrome/browser/resources/options/manage_profile_overlay.js#newcode120 chrome/browser/resources/options/manage_profile_overlay.js:120: PageManager.showPageByName('supervisedUserImport'); On 2014/08/01 17:07:54, michaelpg wrote: > https://codereview.chromium.org/431303003/ Done.

6 years, 4 months ago (2014-08-01 17:13:16 UTC) #3

Dan Beam

6 years, 4 months ago (2014-08-01 17:32:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as 287035 (presubmit successful).

Expand Messages | Collapse Messages