Adds --analyzer2

Adds --analyzer2

This is temporary while I migrate recipes over to the new
switches. I'll remove analyzer2 once that is done.

BUG=398118
TEST=none
R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286307

[Nico, 2014-07-28 21:56:55]

lgtm

https://codereview.chromium.org/426783002/diff/1/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/426783002/diff/1/build/gyp_chromium#newcode193
build/gyp_chromium:193: use_analyzer = len(args) and args[0] == '--analyzer'
optional nit: If you say

  if len(args) and args[0] == '--analyzer2':
    use_analyzer

here, then the existing if does all you need and you don't need to duplicate its
body

[sky, 2014-07-28 22:03:07]

https://codereview.chromium.org/426783002/diff/1/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/426783002/diff/1/build/gyp_chromium#newcode193
build/gyp_chromium:193: use_analyzer = len(args) and args[0] == '--analyzer'
On 2014/07/28 21:56:54, Nico (away) wrote:
> optional nit: If you say
> 
>   if len(args) and args[0] == '--analyzer2':
>     use_analyzer
> 
> here, then the existing if does all you need and you don't need to duplicate
its
> body

The args for the two are different. No doubt I could have made things shorter,
but I held off since one will go away shortly.

[sky, 2014-07-28 22:03:09]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-07-28 22:04:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/426783002/1

[commit-bot: I haz the power, 2014-07-29 03:22:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-07-29 04:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 04:33:34]

Failed to apply patch for testing/buildbot/chromium_trybot.json:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file testing/buildbot/chromium_trybot.json
  Hunk #1 FAILED at 193.
  1 out of 1 hunk FAILED -- saving rejects to file
testing/buildbot/chromium_trybot.json.rej

Patch:       testing/buildbot/chromium_trybot.json
Index: testing/buildbot/chromium_trybot.json
diff --git a/testing/buildbot/chromium_trybot.json
b/testing/buildbot/chromium_trybot.json
index
19d59082a2e065f22ac79df940f0c140436684b8..7257072c5826279fa9d656876dc93e94ad5a46b1
100644
--- a/testing/buildbot/chromium_trybot.json
+++ b/testing/buildbot/chromium_trybot.json
@@ -193,6 +193,7 @@
 
   "gtest_tests_filter_exclusions": [
     ".*gyp[i]?",
+    "build/gyp_chromium",
     "chrome/test/data/.*",
     "content/test/data/.*",
     "DEPS",

[sky, 2014-07-29 13:07:25]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-07-29 13:08:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/426783002/20001

[commit-bot: I haz the power, 2014-07-29 21:46:12]

Change committed as 286307