chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc - Issue 426713002: Revert of Fix the handling of user gestures for external protocol handler dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc

Issue 426713002: Revert of Fix the handling of user gestures for external protocol handler dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc ('k') | chrome/browser/extensions/active_tab_permission_granter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc

diff --git a/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc b/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc

index 720935831417a5e6469de46bc27704891e93fd0d..811a896237f1c663994480a75c608ec1cacee302 100644

--- a/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc

+++ b/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc

@@ -45,12 +45,8 @@ ChromeAutocompleteSchemeClassifier::GetInputTypeForScheme(

// handlable schemes (e.g. "javascript") may be treated as "blocked" by the

// external protocol handler because we don't want pages to open them, but

// users still can.

- //

- // Note that the protocol handler needs to be informed that omnibox input

- // should always be considered "user gesture-triggered", lest it always

- // return BLOCK.

const ExternalProtocolHandler::BlockState block_state =

- ExternalProtocolHandler::GetBlockState(scheme, true);

+ ExternalProtocolHandler::GetBlockState(scheme);

switch (block_state) {

case ExternalProtocolHandler::DONT_BLOCK:

return metrics::OmniboxInputType::URL;