Introduce a helper for OPENFILENAME struct to make certain logic testable.

ui/shell_dialogs/select_file_dialog_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/shell_dialogs/select_file_dialog_win.h"
 
 #include <windows.h>
 #include <commdlg.h>
 #include <shlobj.h>
 
@@ skipping 12 matching lines @@
 #include "base/win/metro.h"
 #include "base/win/registry.h"
 #include "base/win/scoped_comptr.h"
 #include "base/win/shortcut.h"
 #include "base/win/windows_version.h"
 #include "grit/ui_strings.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/base/l10n/l10n_util.h"
+#include "ui/base/win/open_file_name_win.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/shell_dialogs/base_shell_dialog_win.h"
 #include "ui/shell_dialogs/shell_dialogs_delegate.h"
 #include "win8/viewer/metro_viewer_process_host.h"
 
 namespace {
 
 // Given |extension|, if it's not empty, then remove the leading dot.
 std::wstring GetExtensionWithoutLeadingDot(const std::wstring& extension) {
   DCHECK(extension.empty() || extension[0] == L'.');
@@ skipping 723 matching lines @@
     CoTaskMemFree(list);
   }
   return result;
 }
 
 bool SelectFileDialogImpl::RunOpenFileDialog(
     const std::wstring& title,
     const std::wstring& filter,
     HWND owner,
     base::FilePath* path) {
-  OPENFILENAME ofn;
-  // We must do this otherwise the ofn's FlagsEx may be initialized to random
-  // junk in release builds which can cause the Places Bar not to show up!
-  ZeroMemory(&ofn, sizeof(ofn));
-  ofn.lStructSize = sizeof(ofn);
-  ofn.hwndOwner = owner;
-
-  wchar_t filename[MAX_PATH];
-  // According to http://support.microsoft.com/?scid=kb;en-us;222003&x=8&y=12,
-  // The lpstrFile Buffer MUST be NULL Terminated.
-  filename[0] = 0;
-  // Define the dir in here to keep the string buffer pointer pointed to
-  // ofn.lpstrInitialDir available during the period of running the
-  // GetOpenFileName.
-  base::FilePath dir;
-  // Use lpstrInitialDir to specify the initial directory
+  // We use OFN_NOCHANGEDIR so that the user can rename or delete the directory
+  // without having to close Chrome first.
+  ui::win::OpenFileName ofn(owner, OFN_FILEMUSTEXIST | OFN_NOCHANGEDIR);
   if (!path->empty()) {
-    if (IsDirectory(*path)) {
-      ofn.lpstrInitialDir = path->value().c_str();
-    } else {
-      dir = path->DirName();
-      ofn.lpstrInitialDir = dir.value().c_str();
-      // Only pure filename can be put in lpstrFile field.
-      base::wcslcpy(filename, path->BaseName().value().c_str(),
-                    arraysize(filename));
-    }
+    if (IsDirectory(*path))
+      ofn.SetInitialSelection(*path, base::FilePath());
+    else
+      ofn.SetInitialSelection(path->DirName(), path->BaseName());
   }
 
-  ofn.lpstrFile = filename;
-  ofn.nMaxFile = MAX_PATH;
-
-  // We use OFN_NOCHANGEDIR so that the user can rename or delete the directory
-  // without having to close Chrome first.
-  ofn.Flags = OFN_FILEMUSTEXIST | OFN_NOCHANGEDIR;
-
   if (!filter.empty())
-    ofn.lpstrFilter = filter.c_str();
-  bool success = CallGetOpenFileName(&ofn);
+    ofn.Get()->lpstrFilter = filter.c_str();
+  bool success = CallGetOpenFileName(ofn.Get());
   DisableOwner(owner);
   if (success)
-    *path = base::FilePath(filename);
+    *path = ofn.GetSingleResult();
   return success;
 }
 
 bool SelectFileDialogImpl::RunOpenMultiFileDialog(
     const std::wstring& title,
     const std::wstring& filter,
     HWND owner,
     std::vector<base::FilePath>* paths) {
-  OPENFILENAME ofn;
-  // We must do this otherwise the ofn's FlagsEx may be initialized to random
-  // junk in release builds which can cause the Places Bar not to show up!
-  ZeroMemory(&ofn, sizeof(ofn));
-  ofn.lStructSize = sizeof(ofn);
-  ofn.hwndOwner = owner;
-
-  scoped_ptr<wchar_t[]> filename(new wchar_t[UNICODE_STRING_MAX_CHARS]);
-  filename[0] = 0;
-
-  ofn.lpstrFile = filename.get();
-  ofn.nMaxFile = UNICODE_STRING_MAX_CHARS;
   // We use OFN_NOCHANGEDIR so that the user can rename or delete the directory
   // without having to close Chrome first.
-  ofn.Flags = OFN_PATHMUSTEXIST | OFN_FILEMUSTEXIST | OFN_EXPLORER
-               | OFN_HIDEREADONLY | OFN_ALLOWMULTISELECT | OFN_NOCHANGEDIR;
+  ui::win::OpenFileName ofn(owner,
+                            OFN_PATHMUSTEXIST | OFN_FILEMUSTEXIST |
+                                OFN_EXPLORER | OFN_HIDEREADONLY |
+                                OFN_ALLOWMULTISELECT | OFN_NOCHANGEDIR);
 
-  if (!filter.empty()) {
-    ofn.lpstrFilter = filter.c_str();
+  if (!filter.empty())
+    ofn.Get()->lpstrFilter = filter.c_str();
+
+  base::FilePath directory;
+  std::vector<base::FilePath> filenames;
+
+  if (CallGetOpenFileName(ofn.Get()))
+    ofn.GetResult(&directory, &filenames);
+  DisableOwner(owner);
+
+  for (std::vector<base::FilePath>::iterator it = filenames.begin();
+       it != filenames.end();
+       ++it) {
+    paths->push_back(directory.Append(*it));
   }
 
-  bool success = CallGetOpenFileName(&ofn);
-  DisableOwner(owner);
-  if (success) {
-    std::vector<base::FilePath> files;
-    const wchar_t* selection = ofn.lpstrFile;
-    while (*selection) {  // Empty string indicates end of list.
-      files.push_back(base::FilePath(selection));
-      // Skip over filename and null-terminator.
-      selection += files.back().value().length() + 1;
-    }
-    if (files.empty()) {
-      success = false;
-    } else if (files.size() == 1) {
-      // When there is one file, it contains the path and filename.
-      paths->swap(files);
-    } else {
-      // Otherwise, the first string is the path, and the remainder are
-      // filenames.
-      std::vector<base::FilePath>::iterator path = files.begin();
-      for (std::vector<base::FilePath>::iterator file = path + 1;
-           file != files.end(); ++file) {
-        paths->push_back(path->Append(*file));
-      }
-    }
-  }
-  return success;
+  return !paths->empty();
 }
 
 base::string16 SelectFileDialogImpl::GetFilterForFileTypes(
     const FileTypeInfo* file_types) {
   if (!file_types)
     return base::string16();
 
   std::vector<base::string16> exts;
   for (size_t i = 0; i < file_types->extensions.size(); ++i) {
     const std::vector<base::string16>& inner_exts = file_types->extensions[i];
@@ skipping 57 matching lines @@
   return return_value;
 }
 
 SelectFileDialog* CreateWinSelectFileDialog(
     SelectFileDialog::Listener* listener,
     SelectFilePolicy* policy) {
   return new SelectFileDialogImpl(listener, policy);
 }
 
 }  // namespace ui