components/search_engines/template_url_data.h - Issue 426653002: Import keywords for search engines imported from Firefox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/template_url_data.h

Issue 426653002: Import keywords for search engines imported from Firefox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/utility/importer/firefox_importer.cc ('K') | « chrome/utility/importer/firefox_importer.cc ('k') | components/search_engines/template_url_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/search_engines/template_url_data.h

diff --git a/components/search_engines/template_url_data.h b/components/search_engines/template_url_data.h

index b460150b109fa20ead76a85fd66b8a31ff4639a8..384412acaf6954022524456cfa84a26d7adadd5e 100644

--- a/components/search_engines/template_url_data.h

+++ b/components/search_engines/template_url_data.h

@@ -28,6 +28,7 @@ struct TemplateURLData {

// The shortcut for this TemplateURL. |keyword| must be non-empty.

void SetKeyword(const base::string16& keyword);

const base::string16& keyword() const { return keyword_; }

+ bool has_custom_keyword;

Peter Kasting 2014/07/29 18:33:31 I'd like to not introduce this to TemplateURLData.

Nikhil 2014/07/30 07:31:29 Done.

// The raw URL for the TemplateURL, which may not be valid as-is (e.g. because

// it requires substitutions first). This must be non-empty.

« chrome/utility/importer/firefox_importer.cc ('K') | « chrome/utility/importer/firefox_importer.cc ('k') | components/search_engines/template_url_data.cc » ('j') | no next file with comments »