Issue 426633005: Bump up allowed maxAllowedError in webaudio tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 426633005: Bump up allowed maxAllowedError in webaudio tests. (Closed)

Created:
6 years, 4 months ago by Nico

Modified:
6 years, 4 months ago

Reviewers:
Ken Russell (switch to Gerrit), Raymond Toy

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Bump up allowed maxAllowedError in webaudio tests. This allows the test to pass on linux32 after the clang switch. The test passed on 32bit mac already with the same compiler – this turned out to be because clang is allowed to treat sqrtf() as a builtin on mac, but not on linux (due to glibc's math routines setting errno). See the bug for details. BUG=392764 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179182

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	LayoutTests/TestExpectations	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	LayoutTests/webaudio/resources/distance-model-testing.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/426633005/1

6 years, 4 months ago (2014-07-29 20:50:13 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-07-29 22:07:09 UTC) #5

Message was sent while issue was closed.

Change committed as 179182

Expand Messages | Collapse Messages