Encapsulate type in the PropertyHandlerCompiler

Encapsulate type in the PropertyHandlerCompiler

BUG=
R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22700

[Toon Verwaest, 2014-07-28 14:04:50]

PTAL

[Igor Sheludko, 2014-07-30 09:19:47]

lgtm with nits that you can ignore:

https://codereview.chromium.org/426633002/diff/60001/src/ic.cc
File src/ic.cc (right):

https://codereview.chromium.org/426633002/diff/60001/src/ic.cc#newcode942
src/ic.cc:942: Handle<HeapType> type = receiver_type();
You replaced half of the |type| usages with the |receiver_type()|. What about
the other half?

https://codereview.chromium.org/426633002/diff/60001/src/ic.cc#newcode1002
src/ic.cc:1002: !info->IsCompatibleReceiver(*map)) {
Consider 
  !info->IsCompatibleReceiver(TypeToMap(*type, isolate()))
like you did in all the other places.

What about adding IC::IsCompatibleReceiver(info, type) instead of old
AccessorInfo::IsCompatibleReceiver()?

https://codereview.chromium.org/426633002/diff/60001/src/ic.cc#newcode1446
src/ic.cc:1446: !info->IsCompatibleReceiver(*map)) {
Same here.

https://codereview.chromium.org/426633002/diff/60001/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):

https://codereview.chromium.org/426633002/diff/60001/src/x64/stub-cache-x64.c...
src/x64/stub-cache-x64.cc:895: (!callback->HasExpectedReceiverType() ||
It was easier to understand callback->IsCompatibleReceiver(*object) than this
new complex condition.

[Toon Verwaest, 2014-07-30 10:09:28]

Committed patchset #2 manually as r22700 (presubmit successful).

[Igor Sheludko, 2014-07-30 10:37:44]

Hope it's not too late.

https://codereview.chromium.org/426633002/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/426633002/diff/80001/src/objects.cc#newcode465
src/objects.cc:465: bool AccessorInfo::IsCompatibleReceiverType(Isolate*
isolate,
What about making it instance method?

[Igor Sheludko, 2014-07-30 10:51:53]

On 2014/07/30 10:37:44, Igor Sheludko wrote:
> Hope it's not too late.
> 
> https://codereview.chromium.org/426633002/diff/80001/src/objects.cc
> File src/objects.cc (right):
> 
> https://codereview.chromium.org/426633002/diff/80001/src/objects.cc#newcode465
> src/objects.cc:465: bool AccessorInfo::IsCompatibleReceiverType(Isolate*
> isolate,
> What about making it instance method?

Ok, I see.