Fix integration bugs (vboot side)

Fix integration bugs (vboot side)

BUG=chromium-os:8621
TEST=See below

1. Build and run tests of vboot (including linktest)
$ make && make runtests

2. Check if *_stub.o are not in vboot_fw.a
$ nm /build/<board>/usr/lib/vboot_fw.a | grep _stub.o

3. Build and boot x86-generic image
$ ./build_packages --board=x86-generic && ./build_image --board=x86-generic
(Then successfully boot the image you just built)

See CL=4372001 for u-boot side changes

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8967860

[Che-Liang Chiou, 2010-11-03 03:19:58]

Please put on hold regard to Makefiles if you are reviewing.  I'm still trying
ld -r option.

[Che-Liang Chiou, 2010-11-03 04:08:00]

I am sorry for any inconvenience for anyone that is reviewing this CL.

I have tried 'ld -r' approach, and it doesn't seem to work.  And since the 'ar
qc' approach (used in this CL) works fine for the linker, I think it is okay to
use 'ar qc' approach.

If you are reviewing this CL (thank you very much), please also comment on the
Makefiles.  Thank you again.

On 2010/11/03 03:19:58, Che-Liang Chiou wrote:
> Please put on hold regard to Makefiles if you are reviewing.  I'm still trying
> ld -r option.

[Randall Spangler, 2010-11-04 16:34:05]

Does 'make && make runtests' still work?

http://codereview.chromium.org/4266002/diff/1/5
File firmware/include/tpm_lite.h (right):

http://codereview.chromium.org/4266002/diff/1/5#newcode1
firmware/include/tpm_lite.h:1: /* Copyright (c) 2010 The Chromium OS Authors.
All rights reserved.
I'd rename this to tlcl_stub.h, since that's the functions in it.  tpm_lite.h
sounds like it's the full TPM lite interface.

[Bill Richardson, 2010-11-04 16:47:22]

I don't see any problems, other than what Randall already mentioned. Be sure to
build and boot a complete x86-generic image with these changes, and make sure
that cgpt and all the utility/ binaries work correctly.

Thanks.

[Che-Liang Chiou, 2010-11-08 03:43:45]

Thanks for the comments.

I updated the issue text based on your suggestions.  I also built and booted a
complete x86-generic image successfully.

Please take a look at the new CL when you have time.  Thanks again.

http://codereview.chromium.org/4266002/diff/1/5
File firmware/include/tpm_lite.h (right):

http://codereview.chromium.org/4266002/diff/1/5#newcode1
firmware/include/tpm_lite.h:1: /* Copyright (c) 2010 The Chromium OS Authors.
All rights reserved.
On 2010/11/04 16:34:08, Randall Spangler wrote:
> I'd rename this to tlcl_stub.h, since that's the functions in it.  tpm_lite.h
> sounds like it's the full TPM lite interface.
> 

Done.

[Bill Richardson, 2010-11-08 17:06:06]

LGTM!

[Randall Spangler, 2010-11-08 17:21:51]

LGTM, thanks