Issue 426593011: Set autofilled property to false when edit the autofilled text in textarea

Issue 426593011: Set autofilled property to false when edit the autofilled text in textarea (Closed)

Created:
6 years, 4 months ago by ziran.sun

Modified:
6 years, 4 months ago

Reviewers:
tkent, Ilya Sherman

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Set autofilled property to false when edit the autofilled text in textarea R=isherman@chromium.org, tkent@chromium.org BUG=399626 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179586

Patch Set 2 : Update code as per review comments. #

Patch Set 3 : Move expectation file to the same directory as test file. #

Patch Set 4 : put back the file that was removed by mistake. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -0 lines)			Patch
A	LayoutTests/fast/forms/textarea/edit-autofilled-text.html	View	1 2	1 chunk	+67 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/forms/textarea/edit-autofilled-text-expected.txt	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLTextAreaElement.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

tkent

https://codereview.chromium.org/426593011/diff/1/LayoutTests/fast/forms/edit-autofilled-text.html File LayoutTests/fast/forms/edit-autofilled-text.html (right): https://codereview.chromium.org/426593011/diff/1/LayoutTests/fast/forms/edit-autofilled-text.html#newcode1 LayoutTests/fast/forms/edit-autofilled-text.html:1: <head> Please move this test to fast/forms/textarea/. (Or we ...

6 years, 4 months ago (2014-08-04 01:44:55 UTC) #2

ziran.sun

Update code as per review comments. Please review. Thanks! https://codereview.chromium.org/426593011/diff/1/LayoutTests/fast/forms/edit-autofilled-text.html File LayoutTests/fast/forms/edit-autofilled-text.html (right): https://codereview.chromium.org/426593011/diff/1/LayoutTests/fast/forms/edit-autofilled-text.html#newcode17 LayoutTests/fast/forms/edit-autofilled-text.html:17: ...

6 years, 4 months ago (2014-08-04 15:23:47 UTC) #3

tkent

lgtm. You may land Patch Set 4 as is. querySelector is optional. https://codereview.chromium.org/426593011/diff/1/LayoutTests/fast/forms/edit-autofilled-text.html File LayoutTests/fast/forms/edit-autofilled-text.html ...

6 years, 4 months ago (2014-08-04 23:47:02 UTC) #4