LayoutTests/fullscreen/full-screen-not-enabled-when-unsupported.html - Issue 426593010: Set fullscreenEnabled to false when fullscreen is not supported.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/full-screen-not-enabled-when-unsupported.html

Issue 426593010: Set fullscreenEnabled to false when fullscreen is not supported. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <body>

	2 <div>This tests that the <code>fullscreenEnabled</code> property is false when f ullscreen

	3 is not supported as laid out in section 4 of the

	4 <a href="http://fullscreen.spec.whatwg.org/#api">Fullscreen API</a> living

	5 standard</div>

	6 <script src="full-screen-test.js"></script>

	7 <script>

	8 window.internals.settings.setFullscreenEnabled(false);

	9

	10 var iframe = document.documentElement.appendChild(document.createElement('if rame'));
	philipj_slow 2014/08/04 09:24:13 You don't need an iframe to test this, just testin You don't need an iframe to test this, just testing document.webkitFullscreenEnabled would suffice. Ignacio Solla 2014/08/04 11:43:33 I need it, 'allowfullscreen' is not a property of Show quoted text On 2014/08/04 09:24:13, philipj wrote: > You don't need an iframe to test this, just testing > document.webkitFullscreenEnabled would suffice. I need it, 'allowfullscreen' is not a property of document or document.documentElement. It is only a property of iframe: https://developer.mozilla.org/en-US/docs/Web/API/document https://developer.mozilla.org/en-US/docs/Web/API/document.documentElement https://developer.mozilla.org/en/docs/Web/HTML/Element/iframe philipj_slow 2014/08/04 12:18:51 For a top-level document, webkitFullscreenEnabled Show quoted text On 2014/08/04 11:43:33, Ignacio Solla wrote: > On 2014/08/04 09:24:13, philipj wrote: > > You don't need an iframe to test this, just testing > > document.webkitFullscreenEnabled would suffice. > > I need it, 'allowfullscreen' is not a property of document or > document.documentElement. It is only a property of iframe: > https://developer.mozilla.org/en-US/docs/Web/API/document > https://developer.mozilla.org/en-US/docs/Web/API/document.documentElement > https://developer.mozilla.org/en/docs/Web/HTML/Element/iframe For a top-level document, webkitFullscreenEnabled will be true if the fullscreenSupported setting is true and false otherwise, so just testExpected('document.webkitFullscreenEnabled', false) should suffice and is the most direct way to probe the setting. Also testing the iframe case doesn't hurt, of course.
	11 iframe.setAttribute('allowfullscreen', 'true');

	12 testExpected('iframe.contentDocument.webkitFullscreenEnabled', false);

	13 endTest();

	14 </script>

	15 </body>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fullscreen/full-screen-not-enabled-when-unsupported-expected.txt » ('j') | Source/core/dom/FullscreenElementStack.cpp » ('J')