chrome/browser/guest_view/extension_options/extension_options_guest.cc - Issue 426593007: Refactor guest view availability to be API not permission based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_guest.cc

Issue 426593007: Refactor guest view availability to be API not permission based. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: MostLikelyContextType Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/extension_options/extension_options_guest.h ('k') | chrome/browser/guest_view/guest_view_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/extension_options/extension_options_guest.cc

diff --git a/chrome/browser/guest_view/extension_options/extension_options_guest.cc b/chrome/browser/guest_view/extension_options/extension_options_guest.cc

index 8fd477aa9ea7bc57494200fb723fb49044cdf952..3ca78ecfec820868a02aace06a3c3d6843d8e715 100644

--- a/chrome/browser/guest_view/extension_options/extension_options_guest.cc

+++ b/chrome/browser/guest_view/extension_options/extension_options_guest.cc

@@ -36,16 +36,8 @@ ExtensionOptionsGuest::ExtensionOptionsGuest(

ExtensionOptionsGuest::~ExtensionOptionsGuest() {

}

-bool ExtensionOptionsGuest::CanEmbedderUseGuestView(

- const std::string& embedder_extension_id) {

- const extensions::Extension* embedder_extension =

- extensions::ExtensionRegistry::Get(browser_context())

- ->enabled_extensions()

- .GetByID(embedder_extension_id);

- if (!embedder_extension)

- return false;

- return embedder_extension->permissions_data()->HasAPIPermission(

- extensions::APIPermission::kEmbeddedExtensionOptions);

+const char* ExtensionOptionsGuest::GetAPINamespace() {

+ return extensionoptions::kAPINamespace;

}

// static