Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: chrome/browser/guest_view/guest_view_manager.cc

Issue 426593007: Refactor guest view availability to be API not permission based. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/guest_view_manager.cc
diff --git a/chrome/browser/guest_view/guest_view_manager.cc b/chrome/browser/guest_view/guest_view_manager.cc
index ac5473534c3242fd87738bb05c87c75d01e2ebfc..e685d1aff16d31d09ff518fb78ece75705137a92 100644
--- a/chrome/browser/guest_view/guest_view_manager.cc
+++ b/chrome/browser/guest_view/guest_view_manager.cc
@@ -65,12 +65,11 @@ int GuestViewManager::GetNextInstanceID() {
return ++current_instance_id_;
}
-void GuestViewManager::CreateGuest(
- const std::string& view_type,
- const std::string& embedder_extension_id,
- int embedder_render_process_id,
- const base::DictionaryValue& create_params,
- const WebContentsCreatedCallback& callback) {
+void GuestViewManager::CreateGuest(const std::string& view_type,
+ const std::string& embedder_extension_id,
+ content::WebContents* embedder_web_contents,
+ const base::DictionaryValue& create_params,
+ const WebContentsCreatedCallback& callback) {
int guest_instance_id = GetNextInstanceID();
GuestViewBase* guest =
GuestViewBase::Create(context_, guest_instance_id, view_type);
@@ -78,10 +77,8 @@ void GuestViewManager::CreateGuest(
callback.Run(NULL);
return;
}
- guest->Init(embedder_extension_id,
- embedder_render_process_id,
- create_params,
- callback);
+ guest->Init(
+ embedder_extension_id, embedder_web_contents, create_params, callback);
}
content::WebContents* GuestViewManager::CreateGuestWithWebContentsParams(

Powered by Google App Engine
This is Rietveld 408576698