Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_guest.cc

Issue 426593007: Refactor guest view availability to be API not permission based. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/extension_options/extension_options_guest.cc
diff --git a/chrome/browser/guest_view/extension_options/extension_options_guest.cc b/chrome/browser/guest_view/extension_options/extension_options_guest.cc
index d4b3e8b589fb75546cf57c1631ed5944ffdafed8..c844a025ef2cddf87f99c9eeb339795a3c4bc81c 100644
--- a/chrome/browser/guest_view/extension_options/extension_options_guest.cc
+++ b/chrome/browser/guest_view/extension_options/extension_options_guest.cc
@@ -36,16 +36,8 @@ ExtensionOptionsGuest::ExtensionOptionsGuest(
ExtensionOptionsGuest::~ExtensionOptionsGuest() {
}
-bool ExtensionOptionsGuest::CanEmbedderUseGuestView(
- const std::string& embedder_extension_id) {
- const extensions::Extension* embedder_extension =
- extensions::ExtensionRegistry::Get(browser_context())
- ->enabled_extensions()
- .GetByID(embedder_extension_id);
- if (!embedder_extension)
- return false;
- return embedder_extension->permissions_data()->HasAPIPermission(
- extensions::APIPermission::kEmbeddedExtensionOptions);
+const char* ExtensionOptionsGuest::GetAPINamespace() {
+ return extensionoptions::kApiNamespace;
Fady Samuel 2014/08/08 14:55:18 nit: rename constant to kEmbedderAPINamespace for
not at google - send to devlin 2014/08/08 15:25:25 Done.
}
// static

Powered by Google App Engine
This is Rietveld 408576698