Chromium Code Reviews| Index: chrome/browser/guest_view/guest_view_base.h |
| diff --git a/chrome/browser/guest_view/guest_view_base.h b/chrome/browser/guest_view/guest_view_base.h |
| index e42b47ce4a5beaa21fb1cf5657ebbbccb4069665..1729936deeb7df5e3577669c9f72f3d6ebd93293 100644 |
| --- a/chrome/browser/guest_view/guest_view_base.h |
| +++ b/chrome/browser/guest_view/guest_view_base.h |
| @@ -141,11 +141,13 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate, |
| // to destruction. |
| virtual void WillDestroy() {} |
| - // This method is to be implemented by the derived class. It determines |
| - // whether the guest view type of the derived class can be used by the |
| - // provided embedder extension ID. |
| - virtual bool CanEmbedderUseGuestView( |
| - const std::string& embedder_extension_id) = 0; |
| + // This method is to be implemented by the derived class. Access to guest |
| + // views are determined by the availability of the internal extension API |
| + // used to implement the guest view. |
| + // |
| + // This should be the name of the API as it appears in the _api_features.json |
| + // file. |
| + virtual const char* GetApiNamespace() = 0; |
|
Fady Samuel
2014/08/07 23:01:18
nit: Should this be GetAPINamespace?
not at google - send to devlin
2014/08/07 23:02:56
up to you I suppose, I'm not fussed. GetAPINamespa
|
| // This method is to be implemented by the derived class. Given a set of |
| // initialization parameters, a concrete subclass of GuestViewBase can |
| @@ -161,7 +163,7 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate, |
| // This creates a WebContents and initializes |this| GuestViewBase to use the |
| // newly created WebContents. |
| void Init(const std::string& embedder_extension_id, |
| - int embedder_render_process_id, |
| + content::WebContents* embedder_web_contents, |
| const base::DictionaryValue& create_params, |
| const WebContentsCreatedCallback& callback); |