Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: chrome/browser/guest_view/guest_view_manager.h

Issue 426593007: Refactor guest view availability to be API not permission based. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/guest_view_manager.h
diff --git a/chrome/browser/guest_view/guest_view_manager.h b/chrome/browser/guest_view/guest_view_manager.h
index bf46ae9e3b6e085939d6d2ab0996ac9fb2067811..abf1c19b60b2222005f2b67238d893d3890b3bb4 100644
--- a/chrome/browser/guest_view/guest_view_manager.h
+++ b/chrome/browser/guest_view/guest_view_manager.h
@@ -21,6 +21,7 @@ class GURL;
namespace content {
class BrowserContext;
+class WebContents;
} // namespace content
namespace guestview {
@@ -53,12 +54,12 @@ class GuestViewManager : public content::BrowserPluginGuestManager,
typedef base::Callback<void(content::WebContents*)>
WebContentsCreatedCallback;
- void CreateGuest(
- const std::string& view_type,
- const std::string& embedder_extension_id,
- int embedder_render_process_id,
- const base::DictionaryValue& create_params,
- const WebContentsCreatedCallback& callback);
+ void CreateGuest(const std::string& view_type,
+ const std::string& embedder_extension_id,
+ int embedder_render_process_id,
+ content::WebContents* embedder_web_contents,
not at google - send to devlin 2014/07/31 22:07:45 Pity I needed to do this, all I want is a URL.
+ const base::DictionaryValue& create_params,
+ const WebContentsCreatedCallback& callback);
content::WebContents* CreateGuestWithWebContentsParams(
const std::string& view_type,

Powered by Google App Engine
This is Rietveld 408576698