Refactor guest view availability to be API not permission based.

chrome/browser/guest_view/guest_view_base.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_
 #define CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_
 
 #include <queue>
 
 #include "base/memory/weak_ptr.h"
 #include "base/values.h"
 #include "content/public/browser/browser_plugin_guest_delegate.h"
 #include "content/public/browser/render_process_host_observer.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/browser/web_contents_observer.h"
 
 struct RendererContentSettingRules;
 
+namespace extensions {
+class Feature;
+}
+
 // A GuestViewBase is the base class browser-side API implementation for a
 // <*view> tag. GuestViewBase maintains an association between a guest
 // WebContents and an embedder WebContents. It receives events issued from
 // the guest and relays them to the embedder. GuestViewBase tracks the lifetime
 // of its embedder render process until it is attached to a particular embedder
 // WebContents. At that point, its lifetime is restricted in scope to the
 // lifetime of its embedder WebContents.
 class GuestViewBase : public content::BrowserPluginGuestDelegate,
                       public content::RenderProcessHostObserver,
                       public content::WebContentsDelegate,
@@ skipping 104 matching lines @@
   // This method can be overriden by subclasses. This gives the derived class
   // an opportunity to perform setup actions before attachment.
   virtual void WillAttachToEmbedder() {}
 
   // This method is called when the guest WebContents is about to be destroyed.
   //
   // This gives the derived class an opportunity to perform some cleanup prior
   // to destruction.
   virtual void WillDestroy() {}
 
-  // This method is to be implemented by the derived class. It determines
-  // whether the guest view type of the derived class can be used by the
-  // provided embedder extension ID.
-  virtual bool CanEmbedderUseGuestView(
-      const std::string& embedder_extension_id) = 0;
+  // This method is to be implemented by the derived class. Access to guest
+  // views are determined by the availability of the extension Feature returned
+  // by GetFeature().
+  //
+  // This Feature should be an API feature so that it can declare the contexts

[not at google - send to devlin, 2014/08/07 00:25:29]

This comment, and the boilerplate, is making me consider whether this method
should actually return a string representing the API name.

A bit odd, and less generic, but given the comment... safer.

+  // the guest view is available in, *not* a permission which contains no
+  // context information.
+  virtual extensions::Feature* GetFeature() = 0;
 
   // This method is to be implemented by the derived class. Given a set of
   // initialization parameters, a concrete subclass of GuestViewBase can
   // create a specialized WebContents that it returns back to GuestViewBase.
   typedef base::Callback<void(content::WebContents*)>
       WebContentsCreatedCallback;
   virtual void CreateWebContents(
       const std::string& embedder_extension_id,
       int embedder_render_process_id,
       const base::DictionaryValue& create_params,
       const WebContentsCreatedCallback& callback) = 0;
 
   // This creates a WebContents and initializes |this| GuestViewBase to use the
   // newly created WebContents.
   void Init(const std::string& embedder_extension_id,
             int embedder_render_process_id,
+            content::WebContents* web_contents,

[not at google - send to devlin, 2014/08/07 00:25:29]

I think I'll just replace the |embedder_render_process_id| argument with this
|web_contents|. Rename to |embedder_web_contents|. The process ID can be
determined from the WebContents.

             const base::DictionaryValue& create_params,
             const WebContentsCreatedCallback& callback);
 
   void InitWithWebContents(
       const std::string& embedder_extension_id,
       int embedder_render_process_id,
       content::WebContents* guest_web_contents);
 
   bool IsViewType(const char* const view_type) const {
     return !strcmp(GetViewType(), view_type);
@@ skipping 149 matching lines @@
   gfx::Size min_auto_size_;
 
   // This is used to ensure pending tasks will not fire after this object is
   // destroyed.
   base::WeakPtrFactory<GuestViewBase> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GuestViewBase);
 };
 
 #endif  // CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_