Issue 426593002: Move extra_ic_state to the PropertyICCompiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 426593002: Move extra_ic_state to the PropertyICCompiler (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Move extra_ic_state to the PropertyICCompiler BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22635

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -26 lines)			Patch
M	src/ic.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/stub-cache.h	View	8 chunks	+11 lines, -17 lines	1 comment	Download
M	src/stub-cache.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/426593002/diff/1/src/stub-cache.h File src/stub-cache.h (right): https://codereview.chromium.org/426593002/diff/1/src/stub-cache.h#newcode594 src/stub-cache.h:594: // Handlers do not use ...

6 years, 4 months ago (2014-07-28 08:35:58 UTC) #2

Toon Verwaest

6 years, 4 months ago (2014-07-28 10:55:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22635 (presubmit successful).

Expand Messages | Collapse Messages