Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 426583003: Revert of Enable the WebIDL [Exposed] annotation on an interface's members. (Closed)

Created:
6 years, 4 months ago by enne (OOO)
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Revert of Enable the WebIDL [Exposed] annotation on an interface's members. (https://codereview.chromium.org/424163002/) Reason for revert: Causes interactive_ui_tests to timeout Tests: WebViewInteractiveTest.PopupPositioningBasic WebViewInteractiveTest.PopupPositioningMoved See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/38370/steps/interactive_ui_tests/logs/stdio Original issue's description: > Enable the WebIDL [Exposed] annotation on an interface's members. > > Blink only supports [Exposed] as an interface-level annotation right now, > but it also makes sense as a member-level annotation in case certain members > should only be available in a subset of the interface's exposure set. > > The first user for this will be the Web Notifications API, which now > defines requestPermission() to only be exposed on Document, whereas the rest > of the API will be available in both windows and workers. > > BUG=398446 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179418 TBR=haraken@chromium.org,jl@opera.com,ch.dumez@samsung.com,bashi@chromium.org,peter@chromium.org NOTREECHECKS=true NOTRY=true BUG=398446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -489 lines) Patch
M Source/bindings/core/v8/V8WindowShell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/code_generator_v8.py View 2 chunks +5 lines, -25 lines 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_interface.py View 5 chunks +7 lines, -10 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_utilities.py View 2 chunks +0 lines, -51 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 5 chunks +26 lines, -35 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/idls/TestInterface.idl View 2 chunks +0 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 7 chunks +9 lines, -222 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface2.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface2.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface3.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface3.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor4.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor4.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceGarbageCollected.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 3 chunks +8 lines, -11 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperations.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperations.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/ExecutionContextClient.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
enne (OOO)
Created Revert of Enable the WebIDL [Exposed] annotation on an interface's members.
6 years, 4 months ago (2014-08-01 23:25:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/426583003/1
6 years, 4 months ago (2014-08-01 23:26:15 UTC) #2
commit-bot: I haz the power
Change committed as 179426
6 years, 4 months ago (2014-08-01 23:27:48 UTC) #3
haraken
On 2014/08/01 23:27:48, I haz the power (commit-bot) wrote: > Change committed as 179426 This ...
6 years, 4 months ago (2014-08-01 23:39:11 UTC) #4
enne (OOO)
6 years, 4 months ago (2014-08-01 23:43:25 UTC) #5
Message was sent while issue was closed.
On 2014/08/01 at 23:39:11, haraken wrote:
> On 2014/08/01 23:27:48, I haz the power (commit-bot) wrote:
> > Change committed as 179426
> 
> This CL just changed generated code, and thus won't break
interactive_ui_tests...

I bisected and reproed this locally.  It seemed to be the culprit.

Powered by Google App Engine
This is Rietveld 408576698