Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 426563003: Fix mistaken use of promise in multiple-register.html (Closed)

Created:
6 years, 4 months ago by falken
Modified:
6 years, 4 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Fix mistaken use of promise in multiple-register.html service_worker_unregister_and_done was outside of the .then chain, so it would execute early and the test passes regardless of the assertions. BUG=395928 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179020

Patch Set 1 #

Patch Set 2 : rm leakexpectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M LayoutTests/LeakExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/multiple-register.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
falken
6 years, 4 months ago (2014-07-28 07:48:55 UTC) #1
nhiroki
LGTM. Can you remove the suppression referred to in http://crbug.com/397892 if the crash never happens ...
6 years, 4 months ago (2014-07-28 08:05:23 UTC) #2
falken
On 2014/07/28 08:05:23, nhiroki wrote: > LGTM. > > Can you remove the suppression referred ...
6 years, 4 months ago (2014-07-28 08:24:23 UTC) #3
falken
The CQ bit was checked by falken@chromium.org
6 years, 4 months ago (2014-07-28 08:24:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/426563003/20001
6 years, 4 months ago (2014-07-28 08:25:05 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-28 09:27:15 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 09:36:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/13998)
6 years, 4 months ago (2014-07-28 09:36:02 UTC) #8
falken
The CQ bit was checked by falken@chromium.org
6 years, 4 months ago (2014-07-28 10:45:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/426563003/20001
6 years, 4 months ago (2014-07-28 10:46:13 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 10:54:31 UTC) #11
Message was sent while issue was closed.
Change committed as 179020

Powered by Google App Engine
This is Rietveld 408576698