Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 426533003: Use clang as host compiler on android with gn too. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Use clang as host compiler on android with gn too. This ports https://codereview.chromium.org/430383002/ to gn. Patch from brettw in https://codereview.chromium.org/385823002/ , this just activates it. BUG=360311 R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 4 months ago (2014-08-04 21:30:24 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-04 21:50:35 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-04 22:45:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/426533003/1
6 years, 4 months ago (2014-08-04 22:46:28 UTC) #4
Nico
6 years, 4 months ago (2014-08-05 00:13:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 287416 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698