Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 426513002: Remove HTMLOptionsCollection.remove(element) (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : header too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLOptionsCollection.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLOptionsCollection.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
rebase
6 years, 4 months ago (2014-07-29 22:22:13 UTC) #1
philipj_slow
PTAL
6 years, 4 months ago (2014-07-29 22:22:35 UTC) #2
philipj_slow
header too
6 years, 4 months ago (2014-07-29 22:58:34 UTC) #3
philipj_slow
PTAL
6 years, 4 months ago (2014-07-30 08:42:47 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-30 09:22:27 UTC) #5
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-07-30 09:25:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/426513002/40001
6 years, 4 months ago (2014-07-30 09:26:08 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 10:01:01 UTC) #8
Message was sent while issue was closed.
Change committed as 179219

Powered by Google App Engine
This is Rietveld 408576698