Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: ui/views/view_targeter.h

Issue 426443002: Do not call into EventTargeter methods from ViewTargeter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added DCHECK Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/views/view.cc ('k') | ui/views/view_targeter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_VIEW_TARGETER_H_ 5 #ifndef UI_VIEWS_VIEW_TARGETER_H_
6 #define UI_VIEWS_VIEW_TARGETER_H_ 6 #define UI_VIEWS_VIEW_TARGETER_H_
7 7
8 #include "ui/events/event_targeter.h" 8 #include "ui/events/event_targeter.h"
9 #include "ui/views/views_export.h" 9 #include "ui/views/views_export.h"
10 10
11 namespace views { 11 namespace views {
12 12
13 class View; 13 class View;
14 class ViewTargeterDelegate; 14 class ViewTargeterDelegate;
15 15
16 // Contains the logic used to determine the View to which an 16 // A ViewTargeter is installed on a View that wishes to use the custom
17 // event should be dispatched. A ViewTargeter (or one of its 17 // hit-testing or event-targeting behaviour defined by |delegate|.
18 // derived classes) is installed on a View to specify the
19 // targeting behaviour to be used for the subtree rooted at
20 // that View.
21 // TODO(tdanderson): Remove overrides of all EventHandler methods except for
22 // FindTargetForEvent() and FindNextBestTarget().
23 class VIEWS_EXPORT ViewTargeter : public ui::EventTargeter { 18 class VIEWS_EXPORT ViewTargeter : public ui::EventTargeter {
24 public: 19 public:
25 explicit ViewTargeter(ViewTargeterDelegate* delegate); 20 explicit ViewTargeter(ViewTargeterDelegate* delegate);
26 virtual ~ViewTargeter(); 21 virtual ~ViewTargeter();
27 22
28 // A call-through to DoesIntersectRect() on |delegate_|. 23 // A call-through to DoesIntersectRect() on |delegate_|.
29 bool DoesIntersectRect(const View* target, const gfx::Rect& rect) const; 24 bool DoesIntersectRect(const View* target, const gfx::Rect& rect) const;
30 25
31 // A call-through to TargetForRect() on |delegate_|. 26 // A call-through to TargetForRect() on |delegate_|.
32 View* TargetForRect(View* root, const gfx::Rect& rect) const; 27 View* TargetForRect(View* root, const gfx::Rect& rect) const;
33 28
34 protected: 29 protected:
35 // Returns the location of |event| represented as a rect. If |event| is
36 // a gesture event, its bounding box is returned. Otherwise, a 1x1 rect
37 // having its origin at the location of |event| is returned.
38 gfx::RectF BoundsForEvent(const ui::LocatedEvent& event) const;
39
40 // ui::EventTargeter: 30 // ui::EventTargeter:
41 virtual ui::EventTarget* FindTargetForEvent(ui::EventTarget* root, 31 virtual ui::EventTarget* FindTargetForEvent(ui::EventTarget* root,
42 ui::Event* event) OVERRIDE; 32 ui::Event* event) OVERRIDE;
43 virtual ui::EventTarget* FindNextBestTarget(ui::EventTarget* previous_target, 33 virtual ui::EventTarget* FindNextBestTarget(ui::EventTarget* previous_target,
44 ui::Event* event) OVERRIDE; 34 ui::Event* event) OVERRIDE;
45 virtual bool SubtreeCanAcceptEvent( 35 virtual bool SubtreeCanAcceptEvent(
46 ui::EventTarget* target, 36 ui::EventTarget* target,
47 const ui::LocatedEvent& event) const OVERRIDE; 37 const ui::LocatedEvent& event) const OVERRIDE;
48 virtual bool EventLocationInsideBounds( 38 virtual bool EventLocationInsideBounds(
49 ui::EventTarget* target, 39 ui::EventTarget* target,
50 const ui::LocatedEvent& event) const OVERRIDE; 40 const ui::LocatedEvent& event) const OVERRIDE;
51 41
52 private: 42 private:
53 View* FindTargetForKeyEvent(View* view, const ui::KeyEvent& key); 43 View* FindTargetForKeyEvent(View* root, const ui::KeyEvent& key);
44 View* FindTargetForScrollEvent(View* root, const ui::ScrollEvent& scroll);
54 45
55 // ViewTargeter does not own the |delegate_|, but |delegate_| must 46 // ViewTargeter does not own the |delegate_|, but |delegate_| must
56 // outlive the targeter. 47 // outlive the targeter.
57 ViewTargeterDelegate* delegate_; 48 ViewTargeterDelegate* delegate_;
58 49
59 DISALLOW_COPY_AND_ASSIGN(ViewTargeter); 50 DISALLOW_COPY_AND_ASSIGN(ViewTargeter);
60 }; 51 };
61 52
62 } // namespace views 53 } // namespace views
63 54
64 #endif // UI_VIEWS_VIEW_TARGETER_H_ 55 #endif // UI_VIEWS_VIEW_TARGETER_H_
OLDNEW
« no previous file with comments | « ui/views/view.cc ('k') | ui/views/view_targeter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698