Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 426403002: Initial commit of Crashpad (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek, scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Initial commit of Crashpad. This commit contains the basic structure of the project: - LICENSE and related files. - DEPS to check dependencies out into third_party. - README.crashpad files and .gyp files to accompany third_party dependencies. - Infrastructure to run GYP as a gclient hook. - codereview.settings to enable Rietveld code review. - Assorted other administrative and dot-files. Committed: https://chromium.googlesource.com/crashpad/crashpad/+/fbcd680b50e0a6d0cd310066a63b9dcd5de89aef

Patch Set 1 #

Total comments: 5

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+842 lines, -0 lines) Patch
A .clang-format View 1 chunk +18 lines, -0 lines 0 comments Download
A .gitignore View 1 chunk +17 lines, -0 lines 0 comments Download
A AUTHORS View 1 chunk +9 lines, -0 lines 0 comments Download
A CONTRIBUTORS View 1 chunk +12 lines, -0 lines 0 comments Download
A DEPS View 1 chunk +40 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +202 lines, -0 lines 0 comments Download
A build/gyp_crashpad.py View 1 chunk +45 lines, -0 lines 0 comments Download
A codereview.settings View 1 1 chunk +18 lines, -0 lines 0 comments Download
A crashpad.gyp View 1 chunk +28 lines, -0 lines 0 comments Download
A package.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/gmock/README.crashpad View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/gmock/gmock.gyp View 1 chunk +152 lines, -0 lines 0 comments Download
A third_party/gtest/README.crashpad View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/gtest/gtest.gyp View 1 chunk +214 lines, -0 lines 0 comments Download
A third_party/gyp/README.crashpad View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/mini_chromium/README.crashpad View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Mark Mentovai
Here we go!
6 years, 4 months ago (2014-07-30 22:03:25 UTC) #1
Robert Sesek
https://codereview.chromium.org/426403002/diff/1/codereview.settings File codereview.settings (right): https://codereview.chromium.org/426403002/diff/1/codereview.settings#newcode17 codereview.settings:17: VIEW_VC: https://code.google.com/p/swarming/source/detail?repo=default&r= https://chromium.googlesource.com/crashpad/crashpad/+/ https://codereview.chromium.org/426403002/diff/1/package.h File package.h (right): https://codereview.chromium.org/426403002/diff/1/package.h#newcode27 package.h:27: ...
6 years, 4 months ago (2014-07-31 02:59:31 UTC) #2
Mark Mentovai
https://codereview.chromium.org/426403002/diff/1/third_party/mini_chromium/README.crashpad File third_party/mini_chromium/README.crashpad (right): https://codereview.chromium.org/426403002/diff/1/third_party/mini_chromium/README.crashpad#newcode10 third_party/mini_chromium/README.crashpad:10: mini_chromium is a small collection of useful low-level (“base”) ...
6 years, 4 months ago (2014-07-31 03:11:16 UTC) #3
Robert Sesek
LGTM!
6 years, 4 months ago (2014-07-31 03:12:15 UTC) #4
Mark Mentovai
It’s alive! “git cl land” didn’t close the issue for me, though. Seems like that’s ...
6 years, 4 months ago (2014-07-31 03:29:28 UTC) #5
scottmg
https://codereview.chromium.org/426403002/diff/1/third_party/mini_chromium/README.crashpad File third_party/mini_chromium/README.crashpad (right): https://codereview.chromium.org/426403002/diff/1/third_party/mini_chromium/README.crashpad#newcode10 third_party/mini_chromium/README.crashpad:10: mini_chromium is a small collection of useful low-level (“base”) ...
6 years, 2 months ago (2014-09-25 17:50:17 UTC) #7
Mark Mentovai
6 years, 2 months ago (2014-09-25 22:36:07 UTC) #8
Message was sent while issue was closed.
Maybe we’ll go with UTF-8 BOMs. There’s a lot of auto-generated documentation in
here, and it’d be nice if it didn’t have to dumb its quotes down.

Powered by Google App Engine
This is Rietveld 408576698