If we read nothing (EOF) after sending a request on a...

If we read nothing (EOF) after sending a request on a
persistent connection, it also indicates that the server
closed the connection before receiving the request, and we
should resend the request on a new connection.

I refactored the main code of HandleIOError into a new
ShouldResendRequest method so that I can reuse it to handle
the read-nothing case.

R=darin
BUG=2489
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2613

[darin (slow to review), 2008-09-24 23:27:11]

LGTM

can you construct a test for this in http_network_transaction_unittest.cc?  it
should be possible leveraging the mock socket stuff in there.

http://codereview.chromium.org/4264/diff/201/202
File net/http/http_network_transaction.cc (right):

http://codereview.chromium.org/4264/diff/201/202#newcode859
Line 859: !header_buf_len_) {  // We haven't received any response header yet.
nit: i recommend inverting this so that you can return early from the function,
and then move the rest of the "will resend request" code to the remainder of the
function.

[wtc, 2008-09-25 00:46:46]

Please review the new snapshot.  I added a unit test
and changed ShouldResendRequest as you suggested.

[darin (slow to review), 2008-09-25 00:49:50]

LGTM, thanks for the test!

http://codereview.chromium.org/4264/diff/210/12
File net/http/http_network_transaction_unittest.cc (right):

http://codereview.chromium.org/4264/diff/210/12#newcode495
Line 495: // TODO(wtc): share code with KeepAliveConnectionReset.  These two
tests
This is a very good TODO :-)