Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 426373002: Run the NetInfo layout tests. (Closed)

Created:
6 years, 4 months ago by jkarlin
Modified:
6 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

The netinfo layout tests weren't running on several platforms. This reenables netinfo when experimental flag is set. TBR=jam@chromium.org BUG=399052 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286604

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Better solution #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/child/runtime_features.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jkarlin
Jam: You're TBR'd as this is causing lots of broken tests on blink.
6 years, 4 months ago (2014-07-30 21:37:02 UTC) #1
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 4 months ago (2014-07-30 21:44:02 UTC) #2
Julien - ping for review
Committed patchset #3 manually as r286604 (presubmit successful).
6 years, 4 months ago (2014-07-30 21:44:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/426373002/40001
6 years, 4 months ago (2014-07-30 21:45:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 21:45:51 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-07-30 21:45:51 UTC) #6
jam
6 years, 4 months ago (2014-07-31 22:01:27 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698