Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 426323002: Updates gyp_chromium to specify analyzer_output_path (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Updates gyp_chromium to specify analyzer_output_path I was going to output to stdout, but I think that's a bad idea. Now we specify a path. BUG=398118 TEST=none R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/gyp_chromium View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
6 years, 4 months ago (2014-07-30 17:01:13 UTC) #1
Nico
lgtm
6 years, 4 months ago (2014-07-30 17:03:03 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-07-30 17:23:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/426323002/1
6 years, 4 months ago (2014-07-30 17:25:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-30 21:02:17 UTC) #5
sky
6 years, 4 months ago (2014-07-30 23:08:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r286632 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698