src/contexts.cc - Issue 426233002: Land the Fan (disabled)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/contexts.cc

Issue 426233002: Land the Fan (disabled) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Review feedback, rebase and "git cl format" Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/contexts.cc

diff --git a/src/contexts.cc b/src/contexts.cc

index 60cf93f8d35dce48439c70b035d27cc24b2fed95..a2041658a1585d6b2cd4e94a1aa5d8b912c17ec3 100644

--- a/src/contexts.cc

+++ b/src/contexts.cc

@@ -140,8 +140,11 @@ Handle<Object> Context::Lookup(Handle<String> name,

}

VariableMode mode;

InitializationFlag init_flag;

- int slot_index =

- ScopeInfo::ContextSlotIndex(scope_info, name, &mode, &init_flag);

+ // TODO(sigurds) Figure out whether maybe_assigned_flag should

+ // be used to compute binding_flags.

+ MaybeAssignedFlag maybe_assigned_flag;

+ int slot_index = ScopeInfo::ContextSlotIndex(

+ scope_info, name, &mode, &init_flag, &maybe_assigned_flag);

ASSERT(slot_index < 0 || slot_index >= MIN_CONTEXT_SLOTS);

if (slot_index >= 0) {

if (FLAG_trace_contexts) {

« no previous file with comments | « src/contexts.h ('k') | src/data-flow.h » ('j') | no next file with comments »