Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 426123003: Don't ask user to confirm profile deletion while disconnecting sync (Closed)

Created:
6 years, 4 months ago by haitaol1
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

It's decided that it's unnecessary to ask user to confirm profile deletion if he chooses to remove other data while disconnecting sync because the confirmation dialog can get lost sometimes and user's data is left behind. BUG=395441 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287802

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
haitaol1
6 years, 4 months ago (2014-07-29 23:28:03 UTC) #1
haitaol1
ping
6 years, 4 months ago (2014-07-31 16:42:22 UTC) #2
haitaol1
ping
6 years, 4 months ago (2014-07-31 21:05:53 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm Sorry for delay.
6 years, 4 months ago (2014-08-01 13:30:53 UTC) #4
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 4 months ago (2014-08-05 02:08:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/426123003/40001
6 years, 4 months ago (2014-08-05 02:11:26 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 04:01:32 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 04:21:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/36233)
6 years, 4 months ago (2014-08-05 04:21:16 UTC) #9
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 4 months ago (2014-08-06 17:40:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/426123003/40001
6 years, 4 months ago (2014-08-06 17:41:56 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 17:43:43 UTC) #12
Message was sent while issue was closed.
Change committed as 287802

Powered by Google App Engine
This is Rietveld 408576698