Chromium Code Reviews Chromium Code Reviews
Issue
426093003:
Add the copresence component. (Closed)
DescriptionAdd the copresence component.
This CL adds the copresence component that will be used by the Copresence API.
This code exposes the CopresenceClient class. This class provides all the
functionality needed by any user of Copresence, which currently is only the
Chrome API.
A few notes on the CL:
. I have stubbed out as much code as possible while still keeping the
implementation of at least the client in the CL. This required me to
have the proto buffers (since the delegate we use sends its data back
and forth in proto buffs) and the stub RPC handler (which the client
directly depends on).
. The protobufs are automatically generated by pulling them from the server
code and running a tool that strips out unnecessary fields. This has the
unfortunate side effect of pulling out all comments/formatting and leaving
us with no control on naming (unless we go change the server code). This
does ensure though that we are constantly up-to-date with the server protos.
- We also have a few deprecated fields in the protobufs, since they are
still needed on the server for Chrome specific server code. We have
bugs out on the server to fix this and as soon as that happens, we will
be getting rid of all the deprecated fields from here too.
An open question I have is about the .GN files. Are those going to get
autogenerated from the GYPs? Or do I need to manually add them?
R=jochen@chromium.org, willchan@chromium.org
BUG=365493
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287036
Patch Set 1 #
Total comments: 4
Patch Set 2 : #Patch Set 3 : #
Total comments: 2
Patch Set 4 : #Patch Set 5 : #
Total comments: 5
Patch Set 6 : #
Total comments: 4
Patch Set 7 : #Patch Set 8 : #
Messages
Total messages: 21 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
