Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 426083005: Oilpan: Prepare to move RenderSelectionInfoBase to Oilpan heap. (Closed)

Created:
6 years, 4 months ago by tkent
Modified:
6 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Oilpan: Prepare to move RenderSelectionInfoBase to Oilpan heap. Because RenderSelectionInfoBase subclasses don't add Member<> fields, RenderSelectionInfoBase::trace is not virtual. BUG=398342 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180263

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Trace m_repaintContainer too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M Source/core/rendering/RenderSelectionInfo.h View 1 3 chunks +14 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 5 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tkent
Please review this.
6 years, 4 months ago (2014-08-14 07:50:16 UTC) #1
haraken
https://codereview.chromium.org/426083005/diff/20001/Source/core/rendering/RenderSelectionInfo.h File Source/core/rendering/RenderSelectionInfo.h (right): https://codereview.chromium.org/426083005/diff/20001/Source/core/rendering/RenderSelectionInfo.h#newcode57 Source/core/rendering/RenderSelectionInfo.h:57: const RenderLayerModelObject* m_repaintContainer; Can we use a Member for ...
6 years, 4 months ago (2014-08-14 08:13:42 UTC) #2
tkent
https://codereview.chromium.org/426083005/diff/20001/Source/core/rendering/RenderSelectionInfo.h File Source/core/rendering/RenderSelectionInfo.h (right): https://codereview.chromium.org/426083005/diff/20001/Source/core/rendering/RenderSelectionInfo.h#newcode57 Source/core/rendering/RenderSelectionInfo.h:57: const RenderLayerModelObject* m_repaintContainer; On 2014/08/14 08:13:41, haraken wrote: > ...
6 years, 4 months ago (2014-08-14 08:51:23 UTC) #3
haraken
LGTM
6 years, 4 months ago (2014-08-14 08:58:26 UTC) #4
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-14 09:12:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/426083005/40001
6 years, 4 months ago (2014-08-14 09:13:17 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-14 12:03:44 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 14:53:34 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (40001) as 180263

Powered by Google App Engine
This is Rietveld 408576698