Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3079)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 426083004: Remove flag enable_debugger as current debugging code has a very minor influence on unoptimzied cod… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/stub_code_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 38736)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -38,7 +38,6 @@
DEFINE_FLAG(bool, trace_type_check_elimination, false,
"Trace type check elimination at compile time.");
-DECLARE_FLAG(bool, enable_debugger);
DECLARE_FLAG(bool, enable_type_checks);
DECLARE_FLAG(int, optimization_counter_threshold);
DECLARE_FLAG(bool, warn_on_javascript_compatibility);
@@ -1013,8 +1012,7 @@
// No debugger check is done in native functions or for return
// statements for which there is no associated source position.
const Function& function = owner()->parsed_function()->function();
- if ((node->token_pos() != Scanner::kNoSourcePos) &&
- !function.is_native() && FLAG_enable_debugger) {
+ if ((node->token_pos() != Scanner::kNoSourcePos) && !function.is_native()) {
AddInstruction(new(I) DebugStepCheckInstr(node->token_pos(),
RawPcDescriptors::kRuntimeCall));
}
@@ -3118,10 +3116,8 @@
// call.
if (node->value()->IsLiteralNode() ||
node->value()->IsLoadLocalNode()) {
- if (FLAG_enable_debugger) {
- AddInstruction(new(I) DebugStepCheckInstr(
- node->token_pos(), RawPcDescriptors::kRuntimeCall));
- }
+ AddInstruction(new(I) DebugStepCheckInstr(
+ node->token_pos(), RawPcDescriptors::kRuntimeCall));
}
ValueGraphVisitor for_value(owner());
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/stub_code_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698