Source/modules/indexeddb/IDBVersionChangeEvent.cpp - Issue 426063010: IndexedDB: Fixed threading bugs with use of AtomicStrings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/IDBVersionChangeEvent.cpp

Issue 426063010: IndexedDB: Fixed threading bugs with use of AtomicStrings. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switched to proper code-generated static strings like Core creates them. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/BUILD.gn ('K') | « Source/modules/indexeddb/IDBTransaction.cpp ('k') | Source/modules/indexeddb/IndexedDBNames.in » ('j') | Source/modules/indexeddb/IndexedDBNames.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/indexeddb/IDBVersionChangeEvent.cpp

diff --git a/Source/modules/indexeddb/IDBVersionChangeEvent.cpp b/Source/modules/indexeddb/IDBVersionChangeEvent.cpp

index 2127434ae6148a44481f31ab29b346af5c37e2cc..c9763186eac26ffd9c9c585431e555f0bf17e0ec 100644

--- a/Source/modules/indexeddb/IDBVersionChangeEvent.cpp

+++ b/Source/modules/indexeddb/IDBVersionChangeEvent.cpp

@@ -26,6 +26,8 @@

#include "config.h"

#include "modules/indexeddb/IDBVersionChangeEvent.h"

+#include "modules/IndexedDBNames.h"

namespace blink {

@@ -71,11 +73,9 @@ unsigned long long IDBVersionChangeEvent::newVersion(bool& isNull) const

const AtomicString& IDBVersionChangeEvent::dataLoss() const

{

- DEFINE_STATIC_LOCAL(AtomicString, total, ("total", AtomicString::ConstructFromLiteral));

if (m_dataLoss == blink::WebIDBDataLossTotal)

- return total;

- DEFINE_STATIC_LOCAL(AtomicString, none, ("none", AtomicString::ConstructFromLiteral));

- return none;

+ return IndexedDBNames::total;

+ return IndexedDBNames::none;

}

const AtomicString& IDBVersionChangeEvent::interfaceName() const

« Source/modules/BUILD.gn ('K') | « Source/modules/indexeddb/IDBTransaction.cpp ('k') | Source/modules/indexeddb/IndexedDBNames.in » ('j') | Source/modules/indexeddb/IndexedDBNames.in » ('J')