Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1941)

Unified Diff: Source/modules/indexeddb/IDBCursor.h

Issue 426063010: IndexedDB: Fixed threading bugs with use of AtomicStrings. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Switched to proper code-generated static strings like Core creates them. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/indexeddb/IDBCursor.h
diff --git a/Source/modules/indexeddb/IDBCursor.h b/Source/modules/indexeddb/IDBCursor.h
index c414eb065e19f835aa1a1633220fbf1187304ba2..c87c40d378e3e848e3cd507d8327b7da296b1f5c 100644
--- a/Source/modules/indexeddb/IDBCursor.h
+++ b/Source/modules/indexeddb/IDBCursor.h
@@ -52,13 +52,7 @@ class SharedBuffer;
class IDBCursor : public GarbageCollectedFinalized<IDBCursor>, public ScriptWrappable {
public:
- static const AtomicString& directionNext();
- static const AtomicString& directionNextUnique();
- static const AtomicString& directionPrev();
- static const AtomicString& directionPrevUnique();
-
static blink::WebIDBCursorDirection stringToDirection(const String& modeString, ExceptionState&);
- static const AtomicString& directionToString(unsigned short mode);
static IDBCursor* create(PassOwnPtr<blink::WebIDBCursor>, blink::WebIDBCursorDirection, IDBRequest*, IDBAny* source, IDBTransaction*);
virtual ~IDBCursor();
@@ -66,7 +60,7 @@ public:
void contextWillBeDestroyed() { m_backend.clear(); }
// Implement the IDL
- const String& direction() const { return directionToString(m_direction); }
+ const String& direction() const;
ScriptValue key(ScriptState*);
ScriptValue primaryKey(ScriptState*);
ScriptValue value(ScriptState*);

Powered by Google App Engine
This is Rietveld 408576698