IndexedDB: Fixed threading bugs with use of AtomicStrings.

Source/modules/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//third_party/WebKit/Source/bindings/bindings.gni")
 import("//third_party/WebKit/Source/bindings/modules/v8/generated.gni")
 import("//third_party/WebKit/Source/bindings/modules/v8/v8.gni")
 import("//third_party/WebKit/Source/build/make_file_arrays.gni")
 import("//third_party/WebKit/Source/build/scripts/scripts.gni")
 import("//third_party/WebKit/Source/modules/modules.gni")
@@ skipping 66 matching lines @@
   configs += [
     "//third_party/WebKit/Source:config",
     "//third_party/WebKit/Source:inside_blink",
   ]
 
   deps = [
     "//third_party/WebKit/Source/core",
   ]
 }
 
-# GYP version: WebKit/Source/modules/modules.gyp:make_modules_generated
+action("module_names") {
+  script = "../build/scripts/make_names.py"
+
+  module_names_in = "indexeddb/IndexedDBNames.in"
+  inputs = make_names_files + [ module_names_in ]
+
+  outputs = [
+    "$blink_modules_output_dir/IndexedDBNames.cpp",

[jsbell, 2014/08/12 18:46:12]

Should we generate into an indexeddb/ subdir, so that include paths elsewhere
are "modules/indexeddb/IndexedDBNames.h" ?

I don't think we do that for other generated code (e.g. for events and bindings)
so probably *no*, but wanted to raise it as an option.

[cmumford, 2014/08/12 19:30:41]

Good question - I had the same thought and nearly asked you the same question.
We don't do it for other auto-generated code, but it would be more symmetrical
if we did. The header includes do look a bit odd without an indexeddb subdir.

On 2014/08/12 18:46:12, jsbell wrote:

+    "$blink_modules_output_dir/IndexedDBNames.h",
+  ]
+
+  args = [
+    rebase_path(module_names_in, root_build_dir),
+    "--output_dir",
+    rebase_path(blink_modules_output_dir, root_build_dir),
+  ]
+}
+
+# GYP version: WebKit/Source/modules/modules_generated.gyp:make_modules_generated
 group("make_modules_generated") {
   deps = [
     "//third_party/WebKit/Source/core:core_event_interfaces",
     "//third_party/WebKit/Source/bindings/modules:bindings_modules_generated",
+    ":module_names",
   ]
 }