IndexedDB: Fixed threading bugs with use of AtomicStrings.

Source/core/Init.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #ifndef Init_h
 #define Init_h
 
 namespace blink {
 
 class CoreInitializer {
 public:
     CoreInitializer() : m_isInited(false) { }
     // Should be called by clients before trying to create Frames.
-    void init();
+    virtual void init();
 
+    // FIXME: Why is this function static?

[jsbell, 2014/08/12 18:46:12]

... because the initializer instance is held as a static local in
initializeWithoutV8, so there's no convenient reference to it.

I don't have a good suggestion for rewriting the FIXME other than "this is
asymmetrical and that's usually a bad code smell"

[cmumford, 2014/08/12 19:30:41]

Fixing that was unrelated to my change so I decided to leave it alone.

On 2014/08/12 18:46:12, jsbell wrote:

+    static void shutdown();
+
+protected:
     virtual void registerEventFactory();
     virtual void initEventNames();
     virtual void initEventTargetNames();
     virtual void initBindings() { }
 
-    // FIXME: Why is this function static?
-    static void shutdown();
-
-private:
     bool m_isInited;
 };
 
 } // namespace blink
 
 #endif // Init_h