Issue 426063008: [SyncFS] Fix a bug in LevelDBWrapper::Iterator::Next

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 426063008: [SyncFS] Fix a bug in LevelDBWrapper::Iterator::Next (Closed)

Created:
6 years, 4 months ago by peria

Modified:
6 years, 4 months ago

Reviewers:
tzik

CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[SyncFS] Fix a bug in LevelDBWrapper::Iterator::Next If |db_iterator_->Valid()| was false AND |map_iterator_ != db_->pending_.end()|, |Iterator->Next()| did nothing. BUG=None TEST=./unit_tests --gtest_filter="LevelDBWrapperTest.*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287265

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/426063008/1

6 years, 4 months ago (2014-08-03 12:28:19 UTC) #4

Message was sent while issue was closed.

Change committed as 287265

Expand Messages | Collapse Messages