Implement basic interfaces and attributes for DOMMatrix.

Implement basic interfaces and attributes for DOMMatrix.

The DOMMatrix can represent a mathmetical matrix with the purpose of
describing transformations in a graphical context.

The specification:
  http://dev.w3.org/fxtf/geometry/
  
Intent to Implement:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V_bJNtOg0oM

BUG=388780
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179589

[zino, 2014-08-01 07:46:50]

I'm working on DOMMatrix currently.
Because this interface is larger than other interfaces,
I'll upload the changes to split into smaller pieces for good quality review.

Please take a look.

[Rik, 2014-08-01 17:26:39]

On 2014/08/01 07:46:50, zino wrote:
> I'm working on DOMMatrix currently.
> Because this interface is larger than other interfaces,
> I'll upload the changes to split into smaller pieces for good quality review.
> 
> Please take a look.

My implementation for mozilla created a 2D matrix by default and changed it to a
3D matrix if one of the 3D methods was called.
Doing operations on 2D is also faster than 3D so this might speed up the 99%
case.

not lgtm because is2D should be a state bit.

[Rik, 2014-08-01 17:26:46]

https://codereview.chromium.org/426063007/diff/60001/Source/core/dom/DOMMatri...
File Source/core/dom/DOMMatrixReadOnly.cpp (right):

https://codereview.chromium.org/426063007/diff/60001/Source/core/dom/DOMMatri...
Source/core/dom/DOMMatrixReadOnly.cpp:14: && m33() == 1 && m44() == 1;
2D'ness of the matrix depends on how it was initialized and used.
So, 3D should become true if you use one of the 3D methods.

see: http://dev.w3.org/fxtf/geometry/#dom-dommatrixreadonly-is2d

[zino, 2014-08-02 02:24:53]

Thank you for review.

I uploaded a new patch set.
Could you take a look?

https://codereview.chromium.org/426063007/diff/60001/Source/core/dom/DOMMatri...
File Source/core/dom/DOMMatrixReadOnly.cpp (right):

https://codereview.chromium.org/426063007/diff/60001/Source/core/dom/DOMMatri...
Source/core/dom/DOMMatrixReadOnly.cpp:14: && m33() == 1 && m44() == 1;
On 2014/08/01 17:26:46, Rik wrote:
> 2D'ness of the matrix depends on how it was initialized and used.
> So, 3D should become true if you use one of the 3D methods.
> 
> see: http://dev.w3.org/fxtf/geometry/#dom-dommatrixreadonly-is2d

Done.

[zino, 2014-08-04 08:10:58]

Dear Rik and Adam,

Please take a look this CL.
Thank you.

[Rik, 2014-08-04 17:44:52]

lgtm

[abarth-chromium, 2014-08-04 17:54:18]

https://codereview.chromium.org/426063007/diff/100001/Source/core/dom/DOMMatr...
File Source/core/dom/DOMMatrix.cpp (right):

https://codereview.chromium.org/426063007/diff/100001/Source/core/dom/DOMMatr...
Source/core/dom/DOMMatrix.cpp:52: m_is2D = value;
m_is2D = m_is2D && value ?

This seems wrong.  Suppose the matrix becomes non-2D.  Now it can never become
2D again, even if it gets reset to the identity.

[Rik, 2014-08-04 18:41:54]

On 2014/08/04 17:54:18, abarth wrote:
>
https://codereview.chromium.org/426063007/diff/100001/Source/core/dom/DOMMatr...
> File Source/core/dom/DOMMatrix.cpp (right):
> 
>
https://codereview.chromium.org/426063007/diff/100001/Source/core/dom/DOMMatr...
> Source/core/dom/DOMMatrix.cpp:52: m_is2D = value;
> m_is2D = m_is2D && value ?
> 
> This seems wrong.  Suppose the matrix becomes non-2D.  Now it can never become
> 2D again, even if it gets reset to the identity.

That is correct per the spec.
In the discussion, people were worried that a matrix would jump between 2d and
3d while it was being animated.

[abarth-chromium, 2014-08-04 19:29:12]

Ok.  Can you add a test that exercises that behavior?

[zino, 2014-08-05 07:37:41]

On 2014/08/04 19:29:12, abarth wrote:
> Ok.  Can you add a test that exercises that behavior?

I've just added the test case.
Please take a look.

Thank you.

[abarth-chromium, 2014-08-05 18:46:38]

Thanks!  LGTM

[abarth-chromium, 2014-08-05 18:46:41]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-08-05 18:48:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/426063007/120001

[commit-bot: I haz the power, 2014-08-05 22:55:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[commit-bot: I haz the power, 2014-08-06 03:27:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-06 03:27:39]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[zino, 2014-08-06 04:24:52]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-08-06 04:25:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/426063007/120001

[commit-bot: I haz the power, 2014-08-06 04:33:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-08-06 04:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-06 04:40:40]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[zino, 2014-08-06 08:06:36]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-08-06 08:07:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/426063007/120001

[commit-bot: I haz the power, 2014-08-06 09:10:17]

Change committed as 179589