chrome/browser/ui/webui/chromeos/login/l10n_util.cc - Issue 426063005: Allow recommended locales to be set for public sessions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/l10n_util.cc

Issue 426063005: Allow recommended locales to be set for public sessions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix buffer overflow in test. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/login/l10n_util.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/l10n_util.cc b/chrome/browser/ui/webui/chromeos/login/l10n_util.cc

index d8691f1984e2aad440f899b7bf9961c79ca797c9..34a690dcedd22a20ce269d68ee05312756be3294 100644

--- a/chrome/browser/ui/webui/chromeos/login/l10n_util.cc

+++ b/chrome/browser/ui/webui/chromeos/login/l10n_util.cc

@@ -239,7 +239,9 @@ scoped_ptr<base::ListValue> GetLanguageList(

}

base::string16 divider16;

- if (insert_divider) {

+ if (insert_divider && !out_display_names.empty()) {

+ // Insert a divider if requested, but only if

+ // |most_relevant_locales_display_names| is not empty.

divider16 = base::ASCIIToUTF16(kMostRelevantLanguagesDivider);

out_display_names.push_back(divider16);

}