chrome/browser/policy/configuration_policy_handler_list_factory.cc - Issue 426063005: Allow recommended locales to be set for public sessions

Side by Side Diff: chrome/browser/policy/configuration_policy_handler_list_factory.cc

Issue 426063005: Allow recommended locales to be set for public sessions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/chromeos/policy/device_local_account_browsertest.cc ('K') | « chrome/browser/chromeos/policy/device_local_account_browsertest.cc ('k') | chrome/browser/ui/webui/chromeos/login/l10n_util.cc » ('j') | components/policy/resources/policy_templates.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/policy/configuration_policy_handler_list_factory.h"	5 #include "chrome/browser/policy/configuration_policy_handler_list_factory.h"

6	6

7 #include "base/basictypes.h"	7 #include "base/basictypes.h"

8 #include "base/bind.h"	8 #include "base/bind.h"

9 #include "base/memory/scoped_vector.h"	9 #include "base/memory/scoped_vector.h"

10 #include "base/values.h"	10 #include "base/values.h"

(...skipping 766 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
777 new PowerManagementIdleSettingsPolicyHandler(chrome_schema)))));	777 new PowerManagementIdleSettingsPolicyHandler(chrome_schema)))));

778 handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(	778 handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(

779 new LegacyPoliciesDeprecatingPolicyHandler(	779 new LegacyPoliciesDeprecatingPolicyHandler(

780 screen_lock_legacy_policies.Pass(),	780 screen_lock_legacy_policies.Pass(),

781 make_scoped_ptr<SchemaValidatingPolicyHandler>(	781 make_scoped_ptr<SchemaValidatingPolicyHandler>(

782 new ScreenLockDelayPolicyHandler(chrome_schema)))));	782 new ScreenLockDelayPolicyHandler(chrome_schema)))));

783 handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(	783 handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(

784 new ExternalDataPolicyHandler(key::kUserAvatarImage)));	784 new ExternalDataPolicyHandler(key::kUserAvatarImage)));

785 handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(	785 handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(

786 new ExternalDataPolicyHandler(key::kWallpaperImage)));	786 new ExternalDataPolicyHandler(key::kWallpaperImage)));

	787 handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(
	pneubeck (no reviews) 2014/07/30 15:23:19 Does the empty list need some special handling at Does the empty list need some special handling at an early stage? Like ignoring the policy all together? bartfab (slow) 2014/08/05 17:16:24 An empty list is permissible. It means the same th Show quoted text On 2014/07/30 15:23:19, pneubeck wrote: > Does the empty list need some special handling at an early stage? > Like ignoring the policy all together? An empty list is permissible. It means the same thing as not setting the policy at all of course: zero recommended locales. I cannot see why anyone would want to set an empty list but it is technically valid and it is handled correctly by the code.
	788 new SimpleSchemaValidatingPolicyHandler(

	789 key::kSessionLocales,

	790 NULL,

	791 chrome_schema,

	792 SCHEMA_STRICT,

	793 SimpleSchemaValidatingPolicyHandler::RECOMMENDED_ALLOWED,

	794 SimpleSchemaValidatingPolicyHandler::MANDATORY_PROHIBITED)));

787 #endif // defined(OS_CHROMEOS)	795 #endif // defined(OS_CHROMEOS)

788	796

789 return handlers.Pass();	797 return handlers.Pass();

790 }	798 }

791	799

792 } // namespace policy	800 } // namespace policy

OLD	NEW