content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java - Issue 426063002: Fix keycode problems for modified keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

Issue 426063002: Fix keycode problems for modified keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed style issues Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/ime_adapter_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('j') | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

index 36b80513cdbb493fac73603d6a9f1ad3645a2087..be5f4958858afb8af4ceb9c8c6402092d94937bf 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

@@ -243,7 +243,7 @@ public class AdapterInputConnection extends BaseInputConnection {

// Send TAB key event

long timeStampMs = SystemClock.uptimeMillis();

mImeAdapter.sendSyntheticKeyEvent(

- ImeAdapter.sEventTypeRawKeyDown, timeStampMs, KeyEvent.KEYCODE_TAB, 0);

+ ImeAdapter.sEventTypeRawKeyDown, timeStampMs, KeyEvent.KEYCODE_TAB, 0, 0);

} else {

mImeAdapter.sendKeyEventWithKeyCode(KeyEvent.KEYCODE_ENTER,

KeyEvent.FLAG_SOFT_KEYBOARD | KeyEvent.FLAG_KEEP_TOUCH_MODE

@@ -339,10 +339,10 @@ public class AdapterInputConnection extends BaseInputConnection {

boolean result = true;

if (keyCode == KeyEvent.KEYCODE_UNKNOWN) {

result = mImeAdapter.sendSyntheticKeyEvent(

- ImeAdapter.sEventTypeRawKeyDown, SystemClock.uptimeMillis(), keyCode, 0);

+ ImeAdapter.sEventTypeRawKeyDown, SystemClock.uptimeMillis(), keyCode, 0, 0);

result &= mImeAdapter.deleteSurroundingText(beforeLength, afterLength);

result &= mImeAdapter.sendSyntheticKeyEvent(

- ImeAdapter.sEventTypeKeyUp, SystemClock.uptimeMillis(), keyCode, 0);

+ ImeAdapter.sEventTypeKeyUp, SystemClock.uptimeMillis(), keyCode, 0, 0);

} else {

mImeAdapter.sendKeyEventWithKeyCode(

keyCode, KeyEvent.FLAG_SOFT_KEYBOARD | KeyEvent.FLAG_KEEP_TOUCH_MODE);