Issue 425943002: Inline Math.fround in optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 425943002: Inline Math.fround in optimized code. (Closed)

Created:
6 years, 4 months ago by Yang

Modified:
6 years, 4 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+814 lines, -627 lines)			Patch
M	src/arm/lithium-arm.h	View	1 2	3 chunks	+156 lines, -144 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 2	2 chunks	+25 lines, -8 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/arm64/lithium-arm64.h	View	1 2 3	2 chunks	+165 lines, -156 lines	0 comments	Download
M	src/arm64/lithium-arm64.cc	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		3 chunks	+21 lines, -8 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1	3 chunks	+154 lines, -142 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1	2 chunks	+25 lines, -8 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1	4 chunks	+154 lines, -142 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1	2 chunks	+25 lines, -8 lines	0 comments	Download
M	test/mjsunit/constant-folding-2.js	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	test/mjsunit/es6/math-fround.js	View	1	3 chunks	+33 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

Yang

On 2014/07/29 07:44:20, Yang wrote: Ported to x64, arm and arm64 as well. Please review.

6 years, 4 months ago (2014-07-29 08:55:50 UTC) #2

Yang

6 years, 4 months ago (2014-07-29 11:34:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r22665 (presubmit successful).