DescriptionRevert of mac: Toolbar renders incorrectly when downloads bar is open. (https://codereview.chromium.org/419683008/)
Reason for revert:
NSInvalidArgumentException reason Unlocking Focus on wrong view (<NSView: 0x#>), expected <FastResizeView: 0x#>
https://code.google.com/p/chromium/issues/detail?id=397089
Original issue's description:
> mac: Toolbar renders incorrectly when downloads bar is open.
>
> The toolbar's superview chromeContentView was incorrectly sized and was too
> small. This happened because chromeContentView's layout was not being updated
> in -[BrowserWindowController layoutSubviews].
>
> I updated the unit tests in browser_window_controller_unittest.mm with 2 changes:
> - All layout checking should use window coordinates, to ensure consistency.
> - Layout checking should ensure that the frame of each view is within the
> bounds of the superview.
>
> BUG=396740
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285796
TBR=shess@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=396740
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286042
Patch Set 1 #
Created: 6 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|