Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 425853007: Revert of mac: Toolbar renders incorrectly when downloads bar is open. (Closed)

Created:
6 years, 4 months ago by erikchen
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Toolbar renders incorrectly when downloads bar is open. (https://codereview.chromium.org/419683008/) Reason for revert: NSInvalidArgumentException reason Unlocking Focus on wrong view (<NSView: 0x#>), expected <FastResizeView: 0x#> https://code.google.com/p/chromium/issues/detail?id=397089 Original issue's description: > mac: Toolbar renders incorrectly when downloads bar is open. > > The toolbar's superview chromeContentView was incorrectly sized and was too > small. This happened because chromeContentView's layout was not being updated > in -[BrowserWindowController layoutSubviews]. > > I updated the unit tests in browser_window_controller_unittest.mm with 2 changes: > - All layout checking should use window coordinates, to ensure consistency. > - Layout checking should ensure that the frame of each view is within the > bounds of the superview. > > BUG=396740 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285796 TBR=shess@chromium.org NOTREECHECKS=true NOTRY=true BUG=396740 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -59 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 2 chunks +8 lines, -51 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of mac: Toolbar renders incorrectly when downloads bar is open.
6 years, 4 months ago (2014-07-29 01:22:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/425853007/1
6 years, 4 months ago (2014-07-29 01:25:00 UTC) #2
commit-bot: I haz the power
Change committed as 286042
6 years, 4 months ago (2014-07-29 01:26:25 UTC) #3
Scott Hess - ex-Googler
6 years, 4 months ago (2014-07-29 01:42:02 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698